vm: preserve global function declaration restrictions - #65061
Open
subotac wants to merge 1 commit into
Open
Conversation
Keep the global proxy's DontDelete attribute when the sandbox also contains the property, so lexical redeclarations are rejected. Signed-off-by: subotac <73706465+subotac@users.noreply.github.com>
nodejs-github-bot
added
c++
legendecas
reviewed
Aug 6, 2026
Author
|
I used the interceptor because that's where the contextified global declaration check is currently observable. If another workaround there is the wrong direction, is there a vm-context-level hook you'd prefer? |
Member
|
I think the fix should be in V8: #65025 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Global function declarations in a context can be reflected as configurable sandbox properties while V8 tracks their global bindings as non-configurable.
When the property query interceptor finds the sandbox property first, preserve the
DontDeleteattribute from the global proxy. This ensures that a subsequent lexical declaration is rejected with aSyntaxError.Extend the existing restricted-global-property test to cover a function declaration followed by a conflicting lexical declaration.
Fixes: #65025